shim Apple's futex primitives #4142
Merged
+626
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I just left for a 1-week business trip and will have to catch up with stuff when I am back so it could take a bit before I can take a closer look. |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-author
RalfJung
reviewed
Jan 29, 2025
RalfJung
reviewed
Feb 2, 2025
|
|
||
| let is_shared = flags == shared; | ||
| let timeout = clock_timeout.map(|(_, anchor, timeout)| { | ||
| (TimeoutClock::Monotonic, anchor, Duration::from_nanos(timeout)) |
There was a problem hiding this comment.
Please add a comment making that connection.
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
This looks great, thanks! Please squash the commits, then we can land this. Please use the @rustbot author |
rustbot
added
S-waiting-on-author
This is necessary to unblock rust-lang/rust#122408. The documentation for these is available [here](https://developer.apple.com/documentation/os/os_sync_wait_on_address?language=objc). Because the futex wait operations (`os_sync_wait_on_address` et al.) return the number of remaining waiters after returning, this required some changes to the common futex infrastructure, which I've changed to take a callback instead of precalculating the return values.
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to unblock rust-lang/rust#122408. The documentation for these is available here.
Because the futex wait operations (
os_sync_wait_on_addresset al.) return the number of remaining waiters after returning, this required some changes to the common futex infrastructure, which I've changed to take a callback instead of precalculating the return values.