[AIX] Use sa_sigaction instead the union #4250
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
libc
crate implementation for AIX definesstruct sigaction
as containing a unionsa_union
with two members:__su_handler
and__su_sigaction
. This mirrors thestruct sigaction
definition in the AIX system header. Consequently, any reference tosa_sigaction
in Rust code, whether in shipped crates or user code, must be replaced withsa_union.__su_sigaction
for AIX. Additionally, the types of these two union members are declared as function pointers rather thansighandler_t
(i.e.,usize
), as is the case on other platforms. This discrepancy causes compiler errors whensighandler_t
is used as the type for signal handlers. Other operating systems, such as Linux, also define a union forsa_handler
andsa_sigaction
instruct sigaction
. However, thelibc
crate implementations on these platforms definesa_sigaction
directly as a member ofstruct sigaction
rather than as part of a union. This patch modifies thelibc
crate implementation for AIX to definesa_sigaction
as a direct member ofstruct sigaction
, aligning it with implementations for other similar platforms. We will also update affected crates and test cases to reflect this change.Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI