fix combined queues and remove broken retry log link for multi repo queues #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors.rust-lang.org mentions > Homu provides a few simple ways to customize the queue's contents to fit your needs: > > * queue/rust+cargo will combine the queues of the rust and cargo repos (for example). but it appears 963762a broke this by early aborting to a 404 without checking this case
…s, as retry log currently can't handle that fixes rust-lang#157
Skgland
force-pushed
the
fix_grouped_queue
branch
from
23730e6 to
0564d5b
Compare
|
I would prefer to drop support for showing a queue across multiple repositories, rather than trying to fix it. I don't think we need that feature, and dropping support seems likely to be safer/simpler/more maintainable in the long run. |
|
Removing combined queues appears reasonable given how long this breakage went unnoticed, but I like to view the "all" queue as I find it gives a nice overview. |
Skgland
force-pushed
the
fix_grouped_queue
branch
from
828ea89 to
93058ef
Compare
Skgland
commented
Feb 22, 2022
Comment on lines
+121
to
+126
| if repo_label == 'all': | ||
| labels = g.repos.keys() | ||
| else: | ||
| labels = repo_label.split('+') | ||
| if any(label not in g.cfg['repo'] for label in labels): | ||
| abort(404) |
There was a problem hiding this comment.
This suggestion could be applied to remove the support for combining queues with + but keep the all queue
Suggested change
| if repo_label == 'all': | |
| labels = g.repos.keys() | |
| else: | |
| labels = repo_label.split('+') | |
| if any(label not in g.cfg['repo'] for label in labels): | |
| abort(404) | |
| if repo_label == 'all': | |
| labels = g.repos.keys() | |
| elif repo_label in g.cfg['repo']: | |
| labels = [repo_label] | |
| else: | |
| abort(404) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.