Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment explaining why cc does not rebuild on env PATH change #1247

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Add comment explaining why cc does not rebuild on env PATH change #1247

merged 2 commits into from
Oct 19, 2024

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu mentioned this pull request Oct 19, 2024
Merged
RalfJung
RalfJung reviewed Oct 19, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@NobodyXu @RalfJung
Update src/lib.rs
51b9ad2 
Co-authored-by: Ralf Jung <[email protected]>
@NobodyXu NobodyXu requested a review from RalfJung October 19, 2024 07:50
@RalfJung
Copy link
Member

LGTM but I can't approve PRs here.

@NobodyXu NobodyXu merged commit e53eba3 into main Oct 19, 2024
54 checks passed
@NobodyXu NobodyXu deleted the NobodyXu-patch-1 branch October 19, 2024 08:31
@NobodyXu
Copy link
Collaborator Author

Thanks, cc-rs doesn't require approve because I'm the only active maintainer.

1 similar comment
@NobodyXu

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung Awaiting requested review from RalfJung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NobodyXu @RalfJung