Update and rename nex-split-tracker to osrs-splits-the-kodai

[KeyboardIsMagic]

Integrated the features of osrs-splits proposed plugin to the already existing plugin. Changed name to reflect merge.

[runelite-github-app]

nex-split-tracker: faf5bbd189d4e4ae49b6180e27f0b3a56df9c0e2...cdd3adf2a213647a9fbf7ba97791df7300784f52

[tylerwgrass]

Instead of deleting the old plugin file and creating a new one you can instead just replace the repo and hash in plugins/nex-split-tracker

[KeyboardIsMagic]

I didn't think I deleted the old plugin file, I did overwrite that same repo with the new commit which did replace a lot of files and restructured the repo. I made a new fork, changed the name, and updated the url/hash. I'm sorry for any complications this made.

[YvesW]

So generally you want to...

1. Not rename the pluginfile in this repo
2. Add the new config options to your config (and keep the old one), can potentially add sections.
   This way it's very easy to combine your old and new code. Functions can just be disabled via the config.
3. Keep the old configgroup (or write migration code that runs in startup and profilechanged IIRC but there's no reason to do that when the old group works).
4. You can change the name of Plugin.java but IIRC you need to define the old name so it remembers it's on/off state. You can check at what I did with the TimersPlugin when I renamed that (Team plugin has the same IIRC).
5. If you add new functionality that does http requests (not to github/runelite.net/osrs.game/osrs wiki) and the plugin did not have a warning before or the warning does not encompass all new http functionality, you want to put the http functionality behind a config option that's disabled by default and has a warning attached to it.

[KeyboardIsMagic]

-- changed the name osrs-splits-the-kodai back to original -> nex-split-tracker.

-- changed the config group back to original "nexsplittracker"

-- added ConfigItem enableExternalSharing with an informational warning and wrapped all Http requests around this check.

PluginDescriptor name remains "OSRS Splits - The Kodai" as I believe that is a better name for the plugin, I have not yet looked into YvesW suggestion "You can check at what I did with the TimersPlugin when I renamed that (Team plugin has the same IIRC)." Which I will do now and either update the commit or come back here with questions. Thanks for the patience.

[KeyboardIsMagic]

Could you link me the suggested plugin for reference? I look at your repos, and the plugin-hub for "time" and couldn't find the reference you mentioned. Or if I can get away with directly renaming PluginDescriptor that would be tight.

[Nightfirecat]

He's talking about the change he made to the core Timers & Buffs plugin (formerly it was the Timers plugin): runelite/runelite@06de8a6

[YvesW]

I meant the commit NFC linked above indeed! Mostly aiming at configName = "TimersPlugin",

[KeyboardIsMagic]

I understand, thank you.

[KeyboardIsMagic]

I've made those changes, Is there anything else I need to do on my end?
Not sure if I am waiting for review or something else.