Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds securityContext to initConfig #374

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Adds securityContext to initConfig #374

merged 2 commits into from
Apr 5, 2024

Conversation

jcoelho93
Copy link
Contributor

what

  • Makes it an option to add a security context to the initConfig container

why

  • I'm running atlantis in a very restricted cluster and it needs a specific security context

tests

  • I rendered the template and it looks good

references

@jcoelho93
Adds securityContext to initConfig
895dde9 
Makes it an option to add a security context to the initConfig container
@jcoelho93 jcoelho93 requested a review from a team as a code owner April 5, 2024 11:52
@GMartinez-Sisti
Copy link
Member

Hi @jcoelho93! Happy to see a fellow compatriot contributing 😄

There a few extra bits required:

  • Please bump the minor version on the chart, since this is a new feature
  • Update values.yaml to include the new key with a simple description
  • Update docs using make docs to add the new key to the readme file

@jcoelho93
Copy link
Contributor Author

@GMartinez-Sisti done!

@GMartinez-Sisti
Copy link
Member

Thanks for the contribution! 🥳

@GMartinez-Sisti GMartinez-Sisti merged commit b2570cf into runatlantis:main Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMartinez-Sisti GMartinez-Sisti GMartinez-Sisti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcoelho93 @GMartinez-Sisti