Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed runAsUser uid #359

Closed
wants to merge 1 commit into from

Conversation

kvanzuijlen
Copy link
Contributor

what

This changes the default runAsUser uid to 1000 instead of 100

why

Together with runatlantis/atlantis#4304 this will fix #305. This should only be merged when runatlantis/atlantis#4304 has been released.

tests

references

Closes #305

@kvanzuijlen
Copy link
Contributor Author

With the latest changes to runatlantis/atlantis#4304 this change is no longer needed

Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to

@@ -260,7 +260,7 @@ statefulSet:
labels: {}
securityContext:
fsGroup: 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss if this is the right thing to do.
We made changes to Alpine and Debian to match the UID recently and we need to keep backwards compatibility
this could affect users that are not enforcing the default.

@GenPage @GMartinez-Sisti @nitrocode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be closed. There’s another PR fixes the uid to be 100 on both -> runatlantis/atlantis#4304. Please let us know what you think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to merging #4304, is this fix #359 even needed when the values can be overridden for runAsUser?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If runatlantis/atlantis#4304 gets merged in its current state this won't be necessary anymore no.

@kvanzuijlen kvanzuijlen deleted the patch-1 branch March 11, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default uuid wrong if using debian image
4 participants