Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ATLANTIS_EXECUTABLE_NAME and ATLANTIS_SILENCE_NO_PROJECTS envs. #307

Closed
wants to merge 4 commits into from
Closed

feat: add ATLANTIS_EXECUTABLE_NAME and ATLANTIS_SILENCE_NO_PROJECTS envs. #307

wants to merge 4 commits into from

Conversation

weslleycamilo
Copy link

@weslleycamilo weslleycamilo commented Jun 29, 2023 •
edited
Loading

what

  • Adding already available Atlantis flags to be used within helm deployments.

Adding ATLANTIS_EXECUTABLE_NAME and ATLANTIS_SILENCE_NO_PROJECTS

why

  • These environments variables should be added as optional once they are available options for Atlantis.

tests

  • I have tested my changes by deploying locally.

references

  • Atlantis official doc with this flags/envs.

@weslleycamilo weslleycamilo requested a review from a team as a code owner June 29, 2023 19:28
@jamengual
Copy link
Contributor

@weslleycamilo can you bump the miner version, please? Thanks for the contribution

GenPage
GenPage approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@GenPage GenPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump chart version please

@jamengual jamengual added the waiting-on-response Waiting for a response from the user label Nov 16, 2023
@jamengual
Copy link
Contributor

@weslleycamilo could you bump the version please? Thanks.

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.

@github-actions github-actions bot added the Stale label Feb 29, 2024
@github-actions github-actions bot closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GenPage GenPage GenPage approved these changes

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
Stale waiting-on-response Waiting for a response from the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weslleycamilo @jamengual @GenPage