build: Enable Docker Go Cross-compile to improve build times #5223
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspj
requested review from
chenrui333,
lukemassa and
X-Guardian
and removed request for
a team
lukaspj
changed the title
Signed-off-by: Lukas Peter Aldershaab <[email protected]>
Signed-off-by: Lukas Peter Aldershaab <[email protected]>
lukaspj
force-pushed
the
fix/improve-arm-build-time
branch
from
b6b8d35 to
1c26a1a
Compare
X-Guardian
changed the title
X-Guardian
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Thanks @lukaspj, that's a great improvement! I added comparison timings and a reference link to the PR description.
lukemassa
added a commit
to lukemassa/atlantis
that referenced
this pull request
Jan 18, 2025
…unatlantis#5223)" This reverts commit f3ed6c4.
lukemassa
added a commit
to lukemassa/atlantis
that referenced
this pull request
Jan 18, 2025
…unatlantis#5223)" This reverts commit f3ed6c4. Signed-off-by: Luke Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
When cross-compiling, ARM builds especially are very slow due to virtualisation during the build process.
This change makes the builder stage in the Dockerfile run in the host os and instead cross compile to the target architecture.
why
After this change, the atlantis-image Workflow in my fork went from running in 12 minutes to 4 minutes, so a third of the time it previously took.
tests
no cross-compile
cross-compile
references