Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disable cloneurl check flag #5170

Conversation

philslab-ninja
Copy link

@philslab-ninja philslab-ninja commented Dec 16, 2024

what

Adding a new flag to optionally disable the clone URL path check that verifies the clone URL matches the repo name

why

In one of my projects github enterprise unfortunately was setup with a basepath (like git.acme.com/gitlab). Setting ATLANTIS_GITLAB_HOSTNAME to git.acme.com/gitlab results in an error like:
expected clone url to have path "/path/to/repo.git" but had "/gitlab/path/to/repo.git"

Setting the new flag to true disables this check

tests

  • I have tested my changes by building atlantis and running it with the new flag

references

closes #1450

@philslab-ninja philslab-ninja requested review from a team as code owners December 16, 2024 12:43
@philslab-ninja philslab-ninja requested review from chenrui333, nitrocode and X-Guardian and removed request for a team December 16, 2024 12:43
@github-actions github-actions bot added docs Documentation go Pull requests that update Go code labels Dec 16, 2024
@dosubot dosubot bot added the feature New functionality/enhancement label Dec 16, 2024
@philslab-ninja philslab-ninja changed the title Add disable cloneurl check flag feat: add disable cloneurl check flag Dec 16, 2024
@philslab-ninja
Copy link
Author

as discussed in slack a simpler aproach is desired without the need for another flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation feature New functionality/enhancement go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atlantis doesn't work when Gitlab is installed under a relative URL
1 participant