Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added apply-error-label config option #3807

Open
wants to merge 691 commits into
base: main
Choose a base branch
from

Conversation

kvanzuijlen
Copy link
Contributor

@kvanzuijlen kvanzuijlen commented Oct 2, 2023

what

Automatically adds a label to the PR when the apply command failed.

why

Can be used together with #3799. It might be undesired to unlock a project in a partially applied state. This could have users think about it twice before unlocking a project in a partially applied state

tests

  • I have tested my changes by writing unit tests

references

Addition to #3799

@kvanzuijlen kvanzuijlen changed the title feat: Added apply-error label config option feat: Added apply-error-label config option Oct 7, 2023
@jamengual
Copy link
Contributor

@kvanzuijlen do you have time to finish this? Thanks.

@kvanzuijlen kvanzuijlen marked this pull request as ready for review November 15, 2023 19:11
@kvanzuijlen kvanzuijlen requested a review from a team as a code owner November 15, 2023 19:11
@kvanzuijlen
Copy link
Contributor Author

@jamengual Please let me know if extra tests are desired!

@jamengual
Copy link
Contributor

We just need time to review it

@GenPage GenPage added the feature New functionality/enhancement label Dec 12, 2023
@GenPage
Copy link
Member

GenPage commented Dec 12, 2023

@kvanzuijlen Can you resolve conflicts and rebase please?

GenPage
GenPage previously approved these changes Dec 12, 2023
@GenPage GenPage enabled auto-merge (squash) December 12, 2023 00:23
auto-merge was automatically disabled December 12, 2023 20:30

Head branch was pushed to by a user without write access

renovate bot and others added 20 commits January 4, 2025 15:30
…est to 0797cca in .github/workflows/test.yml (main) (runatlantis#5193)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
…drive/utils.go (main) (runatlantis#5194)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
…est to 68464b0 in .github/workflows/test.yml (main) (runatlantis#5196)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
…erfile (main) (runatlantis#5197)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
…/dockerfile (main) (runatlantis#5198)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
…est to 1930320 in .github/workflows/test.yml (main) (runatlantis#5199)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
…/dockerfile (main) (runatlantis#5200)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
…est to 7999141 in .github/workflows/test.yml (main) (runatlantis#5201)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: kvanzuijlen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: kvanzuijlen <[email protected]>
…ub/workflows/scorecard.yml (main) (runatlantis#5204)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
…/workflows/scorecard.yml (main) (runatlantis#5205)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
…in go.mod (main) (runatlantis#5206)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: kvanzuijlen <[email protected]>
… x86 builds) (runatlantis#5207)

Signed-off-by: Dan Urson <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Rui Chen <[email protected]>
Signed-off-by: kvanzuijlen <[email protected]>
….mod (main) (runatlantis#5209)

Signed-off-by: Rui Chen <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Rui Chen <[email protected]>
Signed-off-by: kvanzuijlen <[email protected]>
…ntis#5167)

Signed-off-by: Andrew Borg <[email protected]>
Co-authored-by: PePe Amengual <[email protected]>
Co-authored-by: Simon Heather <[email protected]>
Signed-off-by: kvanzuijlen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Rui Chen <[email protected]>
Co-authored-by: PePe Amengual <[email protected]>
Signed-off-by: kvanzuijlen <[email protected]>
Signed-off-by: kvanzuijlen <[email protected]>
@github-actions github-actions bot added build Relating to how we build Atlantis dependencies PRs that update a dependency file github-actions website blog labels Jan 4, 2025
@kvanzuijlen
Copy link
Contributor Author

@GenPage The sign-off went (horribly) wrong 😞. Would you like for me to open a new PR with cherry-picked changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog build Relating to how we build Atlantis dependencies PRs that update a dependency file docs Documentation feature New functionality/enhancement github-actions go Pull requests that update Go code provider/azuredevops provider/bitbucket provider/github provider/gitlab waiting-on-response Waiting for a response from the user waiting-on-review Waiting for a review from a maintainer website
Projects
None yet
Development

Successfully merging this pull request may close these issues.