Remove unused method argument in the Elastica\SearchableInterface methods #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…::search` and `Elastica\SearchableInterface::count` as they are not unused anymore. Removed Request class
sidz
force-pushed
the
remove-unused-method-argument-and-remove-request-class
branch
from
9809aac to
df87b52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes:
$methodargument from theElastica\SearchableInterface::searchandElastica\SearchableInterface::countas they are not unused anymore.Elastica\Request classas it is not needed anymore.On one hand it's a BC break as signatures are changed but on other hand it is not as we basically didn't clean up code base well before releasing version 8.
$methodargument is not used inside of the methods.Elastica\Requestclass is not needed anymore as right methods are set inside of official elasticsearch SDK