Fixes #1906 - setOption('filter_path', 'responses.hits.hits._source'); #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$search->setOption('filter_path', 'responses.hits.hits._source');
|
Thanks for the contribution. Could you add a changelog entry and a test? Also check the style of the code as CI complains. |
deguif
reviewed
Mar 3, 2021
| * | ||
| * @return $this | ||
| */ | ||
| public function setOption($key, $value) |
There was a problem hiding this comment.
Suggested change
| public function setOption($key, $value) | |
| public function setOption(string $key, $value): self |
Argument $key can probably be type-hinted
| * | ||
| * @return bool | ||
| */ | ||
| public function hasOption($key) |
There was a problem hiding this comment.
Suggested change
| public function hasOption($key) | |
| public function hasOption(string $key): bool |
| * | ||
| * @return $this | ||
| */ | ||
| public function addOption($key, $value) |
There was a problem hiding this comment.
Suggested change
| public function addOption($key, $value) | |
| public function addOption(string $key, $value): self |
| * | ||
| * @return mixed | ||
| */ | ||
| public function getOption($key) |
There was a problem hiding this comment.
Suggested change
| public function getOption($key) | |
| public function getOption(string $key) |
| /** | ||
| * @return array | ||
| */ | ||
| public function getOptions() |
There was a problem hiding this comment.
Suggested change
| public function getOptions() | |
| public function getOptions(): array |
| * | ||
| * @return bool | ||
| */ | ||
| protected function _validateOption($key) |
There was a problem hiding this comment.
Suggested change
| protected function _validateOption($key) | |
| protected function _validateOption(string $key): bool |
| /** | ||
| * @return $this | ||
| */ | ||
| public function clearOptions() |
There was a problem hiding this comment.
Suggested change
| public function clearOptions() | |
| public function clearOptions(): self |
| * | ||
| * @return $this | ||
| */ | ||
| public function setOptions(array $options) |
There was a problem hiding this comment.
Suggested change
| public function setOptions(array $options) | |
| public function setOptions(array $options): self |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$search->setOption('filter_path', 'responses.hits.hits._source');
#1906