Deprecate Util::getParamName() #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
force-pushed
the
deprecate-util-base-name
branch
from
381a2a3 to
524230b
Compare
|
Can you share some details behind this change? |
|
Just added a description to share the details I have in mind behind this change. |
ruflin
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment: #1813 (comment)
I'm proposing to deprecate
Elastica\Util::getParamName()as it's too generic and used in context of multiple classes with different naming conventions likeQuery,AggregationandProcessor(it checks for exampleQuerysuffix for every class, even when the class is not related to a Query). Instead I moved logic toQuerysuffix in the base Query class. This can be replicated for base classesAggregationandProcessorlater to handle their suffix in an unified way.