Improve phpunit config and fail builds on warning, incomplete and ris…

…ky test cases. Execute tests in the random order (#2225)
ruflin · Aug 15, 2024 · e2cb89b · e2cb89b
1 parent 32b9cc1
commit e2cb89b
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 18 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -2,26 +2,32 @@
 <!-- https://phpunit.de/manual/current/en/appendixes.configuration.html -->
 <phpunit
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-        xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
+        xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
         colors="true"
         beStrictAboutOutputDuringTests="true"
         verbose="true"
+        failOnWarning="true"
+        failOnIncomplete="true"
+        failOnRisky="true"
+        executionOrder="random"
         bootstrap="tests/bootstrap.php"
 >
-  <coverage>
-    <include>
-      <directory>src/</directory>
-    </include>
-    <exclude>
-      <file>src/Query/Match.php</file>
-    </exclude>
-  </coverage>
-  <listeners>
-    <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"/>
-  </listeners>
-  <testsuites>
-    <testsuite name="default">
-      <directory>tests/</directory>
-    </testsuite>
-  </testsuites>
+    <coverage>
+        <include>
+            <directory>src/</directory>
+        </include>
+        <exclude>
+            <file>src/Query/Match.php</file>
+        </exclude>
+    </coverage>
+
+    <listeners>
+        <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"/>
+    </listeners>
+
+    <testsuites>
+        <testsuite name="default">
+            <directory>tests/</directory>
+        </testsuite>
+    </testsuites>
 </phpunit>
diff --git a/tests/Node/InfoTest.php b/tests/Node/InfoTest.php
@@ -50,7 +50,7 @@ public function testHasPlugin(): void
         $this->assertFalse($info->hasPlugin('foo'));
 
         if (\version_compare($_SERVER['ES_VERSION'], '8.4.0', '>=')) {
-            $this->markTestIncomplete('The Ingest Attachment plugin is now included in Elasticsearch. https://www.elastic.co/guide/en/elasticsearch/plugins/8.4/ingest-attachment.html');
+            $this->markTestSkipped('The Ingest Attachment plugin is now included in Elasticsearch. https://www.elastic.co/guide/en/elasticsearch/plugins/8.4/ingest-attachment.html');
         } else {
             $this->assertTrue($info->hasPlugin('ingest-attachment'));
         }