-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add foreign key #157
base: master
Are you sure you want to change the base?
Add foreign key #157
Conversation
Add foreign key functionality
Update README.md
This is can not be merged as it breaks PHP 5.2 compatibility. |
@garex php 5.2 is not supported anymore. Nobody "serious" should be using it actually... https://secure.php.net/supported-versions.php Even php 5.3 & 5.4 are also EOL... |
@brutuscat It's not an argument. It's supported in WordPress and WordPress is a huge part of market. Nobody serious should throw out away customers because of caprice. This migration tool is only one that supported PHP 5.2. In other case you should switch to https://phinx.org/ All mature and serious developers thinks about backward compatibility. Also all serious developers MUST know what is composer.json and what does means this string: "php": ">=5.2.0". It means includes and not more than. Just use 5.2 version or use those "singularize" method only with copyright notice or better avoid it. This is all what should need. |
@garex I don't want to get into this discussion, but wordpress should upgrade. It is not responsible from their part to maintain compatibility with a php version no longer maintained. |
Hi everyone - firstly @brutuscat - thank you for your contribution, very much appreciated. Honestly I am on the fence about this. I have not used PHP in a couple of years and have not used this library in a bit longer. Thus, I dont have a horse in this race. Giving that WP does represent a large user base there is some slight sense in supporting it. But on the flip-side, a deprecated version is a deprecated version. It comes down to this: I'm not in a position to maintain this project and possibly deal with any issues that might arise in maintaining backwards compatibility. If someone else wanted to step in and assume control and ownership, maybe thats the best route forward. |
@ruckus I can take it. The only reason I've choose your lib is 5.2 compatibility. Also in this concrete feature there is no big problems to make it 5.2 compatible. |
@bbwebconsult added the ability to add/remove FK in the MySQL driver. Since we don't have much exp with other DBs, we welcome commits for the other drives too!