This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Removed self-hosted YAML Serializer and PsychedYAML #6536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is required since YAML is in a gem, and we load the list of plugins & settings before Bundler.setup, so using the Psych gem will mean no Bundler users can choose what version of pysch they use |
hsbt
force-pushed
the
remove-self-hosted-yaml
branch
from
1a26d67 to
6eda701
Compare
hsbt
force-pushed
the
remove-self-hosted-yaml
branch
from
6eda701 to
9cdaaa3
Compare
hsbt
force-pushed
the
remove-self-hosted-yaml
branch
from
9cdaaa3 to
d1f2f87
Compare
|
I know the problem that is psych activation problem. But Bundler already uses psych directly. Users couldn't specify its version. |
hsbt
changed the title
|
I thinking, what @segiddins said makes sense. But what @hsbt says makes sense too. Even though we have our own YAML implementation in order to not interfere with |
hsbt
force-pushed
the
remove-self-hosted-yaml
branch
from
d1f2f87 to
4f01b28
Compare
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
It is not compatible with YAML spec of the standard library of Ruby.
I did revert a feature in last year: ruby/psych#336
What was your diagnosis of the problem?
YAMLSerializerwas introduced from bfd4be3I'm not sure why that was required.
What is your fix for the problem, implemented in this PR?
Removed
YAMLSerializer. and useYAMLprovided bypyched_yaml.