chore: hooks: use on_communication_update (frappe#1594)

helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py

@@ -714,6 +714,20 @@ def apply_sla(self):
 		sla = frappe.get_doc("HD Service Level Agreement", self.sla)
 		sla.apply(self)
 
+	# `on_communication_update` is a special method exposed from `Communication` doctype.
+	# It is called when a communication is updated. Beware of changes as this effectively
+	# is an external dependency. Refer `communication.py` of Frappe framework for more.
+	# Since this is called from communication itself, `c` is the communication doc.
+	def on_communication_update(self, c):
+		# If communication is outgoing, then it is a reply from agent.
+		if c.sent_or_received == "Sent":
+			self.status = "Replied"
+		# Fetch description from communication if not set already. This might not be needed
+		# anymore as a communication is created when a ticket is created.
+		self.description = self.description or c.content
+		# Save the ticket, allowing for hooks to run.
+		self.save()
+
 
 def has_permission(doc):
 	user = frappe.session.user

helpdesk/hooks.py

@@ -18,9 +18,6 @@
 ]
 
 doc_events = {
-	"Communication": {
-		"after_insert": "helpdesk.helpdesk.hooks.communication.after_insert",
-	},
 	"Contact": {
 		"before_insert": "helpdesk.helpdesk.hooks.contact.before_insert",
 	},