Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS 2 Jazzyに対応します #158
ROS 2 Jazzyに対応します #158
Changes from 13 commits
7fdbb47
40749ac
1491067
45d2ccb
537cc7d
3531db7
43216c2
3e9401e
fa714c2
5f62ad7
adc8fea
e96d86a
14f8e01
e741c8f
33344ef
57d513c
39058b9
26abaeb
a8d0a83
94a7527
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gazeboシミュレータが起動中に落ちました。
@chama1176 さんの環境では正常に起動しましたでしょうか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらの環境だとGUIまわりでエラーが起きていているようです。
WaylandでなくXorgに切り替えると上記エラーは表示されなくなりましたが、limitsとmimic jointまわりでエラーが出ています。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR作成時は私の方では動作確認できていました。
変更入っている可能性もあるので再度確認してみます
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
私の環境でも落ちる現象が再現しました
確認します
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR作成時(おそらくv8.5.0)からv8.6.0になって差分が大きそうなので、今のバージョンで動くように修正します
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
物理エンジンにmimic contraintsがないエラー
は公式でも認識されているようです。
ros-controls/gz_ros2_control#340
DART使う場合は無視してとのことのようです。bulletに変更することで回避できるようです
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
に関してですが、下記の通り、SDF側に定義されていないだけのようなので、問題はなさそうです。
gazebosim/gz-sensors#306
探している中で見つけましたが、今後はgz_frame_id等は廃止になってframe_idに統一されるようです。
gazebosim/sdformat#1454
ただしsdformat15からの変更のようなので、sdformat14を使っている現在のgz-sim8.x.xではframe_idで設定してもワーニングが出ます。
こちらのコミットでframe_idに変更しました
rt-net/sciurus17_description@0bb3899
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GripperActionControllerの廃止に関してはmsg型なども変わり変更量がさすがに多いので、
調査して別PRで対応検討とさせていただきたいです
ros-controls/ros2_controllers#1002
ちょうどこのPRを作成したあたりのタイミングでmainにmergeされた新機能のようです
こちらにIssue起案しました
#163
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kuwamai
記載いただいた事項に関して状況確認と修正行いましたので、改めて確認いただけると幸いです
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chama1176
ご確認ありがとうございます!
エラーが出ていないことを確認しました。
先にdescriptionパッケージのほうApproveします