Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

実機動作に必要なパラメータ追加 #7

Merged
merged 9 commits into from
Nov 6, 2023

Conversation

Kuwamai
Copy link
Collaborator

@Kuwamai Kuwamai commented Nov 1, 2023

What does this implement/fix?

実機との通信に使用するポート名やボーレートなどのパラメータ、関節軸の設定を追加しました。

Does this close any currently open issues?

しません

How has this been tested?

Any other comments?

Checklists

@Kuwamai Kuwamai added the Type: Feature New Feature label Nov 1, 2023
@Kuwamai Kuwamai self-assigned this Nov 1, 2023
@Kuwamai Kuwamai marked this pull request as ready for review November 1, 2023 10:02
@Kuwamai Kuwamai requested a review from ShotaAk November 1, 2023 10:02
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました。
サーボの電流トルク比を修正お願いします

urdf/sciurus17.ros2_control.xacro Outdated Show resolved Hide resolved
urdf/sciurus17.ros2_control.xacro Outdated Show resolved Hide resolved
urdf/sciurus17.ros2_control.xacro Outdated Show resolved Hide resolved
urdf/sciurus17.ros2_control.xacro Outdated Show resolved Hide resolved
Kuwamai and others added 4 commits November 2, 2023 14:59
Co-authored-by: Shota Aoki <[email protected]>
Co-authored-by: Shota Aoki <[email protected]>
Co-authored-by: Shota Aoki <[email protected]>
Co-authored-by: Shota Aoki <[email protected]>
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit e83a2e4 into ros2 Nov 6, 2023
2 checks passed
@ShotaAk ShotaAk deleted the support_ros2_controller branch November 6, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants