fix v3.0.1 #6
Merged
fix v3.0.1 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShotaAk
suggested changes
Jun 10, 2024
.DS_Store
Outdated
There was a problem hiding this comment.
.DS_Store ファイルをすべて削除してください。
（.gitignoreファイルを追加してなかったですね。。。）
Comment on lines
84
to
86
| g_timer1 = timerBegin(1000000); //1us | ||
| timerAttachInterrupt(g_timer1, &onTimer1); | ||
| timerAlarm(g_timer1, 500, true, 0); //2kHz |
There was a problem hiding this comment.
コメントの1usですが、実際に設定しているのは 1MHzなので記述を変えたいです。
Suggested change
| g_timer1 = timerBegin(1000000); //1us | |
| timerAttachInterrupt(g_timer1, &onTimer1); | |
| timerAlarm(g_timer1, 500, true, 0); //2kHz | |
| g_timer1 = timerBegin(1000000); // 1Mhz = 1/1us | |
| timerAttachInterrupt(g_timer1, &onTimer1); | |
| timerAlarm(g_timer1, 500, true, 0); // 500us = 1/2kHz |
There was a problem hiding this comment.
周波数入力の時は、1MHz(1us)のように周波数(時間)でコメント
タイマカウントのところは、500*1us=500us(2kHz)のように時間(周波数)でコメントしました
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Arduino ESP32パッケージ3.0.1に対応したプログラムの改善
Does this close any currently open issues?
#3 がクローズになります。
How has this been tested?
実機でテストしました
Any other comments?
ありません
Checklists