Fix ever-growing call stacks #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-entering domains was happening additively, instead of replacing the active domain as it should've been doing. - Wrapping for re-entering wasn't happening if the domain at the time of binding was NULL. This was incorrect! If the domain was NULL at binding time, and non-NULL at the time of resolution, then the domain needs to be set back to NULL before the handler is invoked! - Fixed the cpp test that had the wrong value all along - Added more tests to catch regressions in this area
jcheng5
force-pushed
the
bugfix/promise-domain-stack-overflow
branch
from
d064234 to
bd03f8b
Compare
This was referenced Nov 27, 2024
wch
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114, helps but doesn't totally fix https://github.com/jcheng5/shinychat/issues/16