Fixes 2wp tests due to lovell changes. #208
Closed
+102
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julia-zack
reviewed
Jan 27, 2025
| @@ -1197,30 +1187,33 @@ const assertReleaseBtcEvent = (releaseBtcEvent, releaseRequestedEvent) => { | |||
| expect(releaseBtcEvent.arguments.releaseRskTxHash).to.be.equal(releaseRequestedEvent.arguments.rskTxHash); | |||
| }; | |||
|
|
|||
| const assertSuccessfulPegoutEventsAreEmitted = async (pegoutsEvents, pegoutRequestReceivedTransactionHash, senderRecipientInfo, pegoutValueInSatoshis, bridgeStateAfterPegoutCreation) => { | |||
|
|
|||
| const assertSuccessfulPegoutEventsAreEmitted = async (pegoutsEvents, pegoutRequestReceivedTransactionHash, senderRecipientInfo, pegoutValueInWeisBN, pegoutValueInSatoshis, bridgeStateBeforePegoutCreation, bridgeStateAfterPegoutCreation) => { | |||
There was a problem hiding this comment.
i think is weird to receive both pegoutValueInWeis and pegoutValueInSatoshis. We could just receive the satoshis value and do the conversion to weis inside the method, wdyt?
There was a problem hiding this comment.
Yep, I agree, but none of the conversion tools round it like the Bridge does. I haven't been able to convert the weis values to satoshis like the Bridge, so, I felt forced to hard code it here.
There was a problem hiding this comment.
oh okey, i see.
what if we simplify the expectedPegoutValueInSatoshi? Is the same?
julia-zack
reviewed
Jan 27, 2025
julia-zack
approved these changes
Jan 27, 2025
jeremy-then
force-pushed
the
add-migration-utxos-test
branch
from
9685358 to
8bfe343
Compare
jeremy-then
force-pushed
the
fix-tests-for-svp
branch
from
9e0f53b to
b86b89d
Compare
|
julia-zack
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.