Adds migrate utxos test #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-then
force-pushed
the
add-migration-utxos-test
branch
from
cf73641 to
9685358
Compare
julia-zack
reviewed
Jan 27, 2025
jeremy-then
force-pushed
the
add-register-svp-spend-tx-test
branch
from
6287d0b to
2763721
Compare
jeremy-then
force-pushed
the
add-migration-utxos-test
branch
from
9685358 to
8bfe343
Compare
|
julia-zack
reviewed
Jan 28, 2025
Comment on lines
487
to
491
| const migrationReleaseBtcTxInputsTxHashes = migrationReleaseBtcTransaction.ins.map(input => input.hash.reverse().toString('hex')); | ||
| const svpSpendTxUtxoHashesNotPresentInTheBridgeStateBeforeActivation = findSvpSpendTxUtxoHashNotPresentInTheBridgeStateBeforeActivation(bridgeStateBeforeActivation.activeFederationUtxos, migrationReleaseBtcTxInputsTxHashes); | ||
| expect(svpSpendTxUtxoHashesNotPresentInTheBridgeStateBeforeActivation.length).to.be.equal(1, 'There should be one missing hash, the utxo that was sent to the Proposed federation in the SVP Spend transaction.'); | ||
| const actualSvpSpendTxHash = svpSpendTxUtxoHashesNotPresentInTheBridgeStateBeforeActivation[0]; | ||
| expect(actualSvpSpendTxHash).to.be.equal(svpSpendBtcTransaction.getId(), 'The missing hash should be the SVP Spend transaction hash.'); |
There was a problem hiding this comment.
can't you just search for the svpSpendBtcTransactionHash in the migrationReleaseBtcTxInputsTxHashes ?
There was a problem hiding this comment.
I renamed some of these variables. Also, what I usually do is connect everything in multiple ways to ensure they all connect.
In this section, I'm not only making sure the "svpSpendBtcTransactionHash" is in the migration transaction (indirectly), but I'm also making sure all the utxos that were in the Bridge are in the migration transaction as well.
Check now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.