Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the gas shipped #35

Closed
wants to merge 2 commits into from

Conversation

fgregoribattista
Copy link

Fix thisissue

@ilanolkies
Copy link
Contributor

We are discussing if we should a void using this module by default since some libraries use gas and others use gasLimit. The new version we are discussing will need developers to run the estimations on their own, the module will be out there so they can use it as best fits. For now we are releasing #33 that passes down any parameter

@fgregoribattista
Copy link
Author

fgregoribattista commented Nov 24, 2021

Yes I know, for this reason I try to talk with you yesterday in open slack.
Anyway the solution that you mentioned only verify the gas limit not the gas. I understand that you pass all the arguments but not maped the gas to gasLimit, so the gasLimit is calculate by the estimated.

@ilanolkies
Copy link
Contributor

Hi! We are closing it via #37

@ilanolkies ilanolkies closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The provider does not consider the gas shipped.
2 participants