-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plugin] Live stream canvas via webrtc #976
Conversation
…lize-stylesheet-contents
…web-io/rrweb into serialize-stylesheet-contents
…lize-stylesheet-contents
…/rrweb into inline-image-test-cases
…e-image-test-cases
When iframes get inserted they create untracked elements, both on the dom and rrdom side. Because they are untracked they generate negative numbers when fetching the id from mirror. This creates a problem when comparing and fetching ids across mirrors. This commit tries to get away from using negative ids as much as possible in rrdom's comparisons
Co-authored-by: Yun Feng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is very innovative both in design and implementation. Actually, I've used this branch many times for quicker debugging of some issues. I'm looking forward to using it in the main branch.
Co-authored-by: Yun Feng <[email protected]>
Co-authored-by: Yun Feng <[email protected]>
Hi @Juice10 , I'm exploring video streaming recording via this plugin, do we have any examples for the same for the video? Thanks. |
@Code-Crash I've created a PR to also do this for video, check it out here: #1046 |
Thanks @Juice10 , will have a look |
Adds plugin to live stream contents of canvas elements via webrtc
Example of live streaming via
yarn live-stream
webrtc-1080p.mov
Instructions
Record side
Replay Side
Includes the following hooks for plugins
Record/Replay plugins
.getMirror
exposes the mirror to pluginsReplay plugins
.onBuild
called whenever a node was added to the domOther things this PR touches
"composite": true
andreferences
Extra
Diagram of how the plugin works (PDF)