Code

Fix performance of splitCssText #1615

Code

Merged

eoghanmurray merged 25 commits intorrweb-io:masterrrweb-io/rrweb:masterfrom eoghanmurray:fix-1603eoghanmurray/rrweb:fix-1603Copy head branch name to clipboardJan 10, 2025

+121-14

Commits

Commits on Jan 10, 2025

• Fix bug where the right split point was not being picked for the 3rd section onwards

  eoghanmurray

  committed
  a065eaf

  Copy full SHA for a065eaf

• Add test to put splitCssText through it's paces with a large file

  eoghanmurray

  committed
  e2fe660

  Copy full SHA for e2fe660

• Introduce a limit which causes the 'efficiently' test to fail

  eoghanmurray

  committed
  2f663d4

  Copy full SHA for 2f663d4

• Fix that it wasn't able to find a split when both halves were identical

  eoghanmurray

  committed
  8ba3b54

  Copy full SHA for 8ba3b54

• Fix poor 'crawling' performance in this part of the algorithm for large css texts - e.g. for a (doubled) benchmark.css, we were running normalizeCssText 9480 times before k got to the right place

  eoghanmurray

  committed
  61e8b5f

  Copy full SHA for 61e8b5f

• Need to take larger jumps to be efficient; use the scaling factor to make better guess at how big a jump to make

  Show description for 3474cb2
  eoghanmurray

  committed
  3474cb2

  Copy full SHA for 3474cb2

• Add changeset

  eoghanmurray

  committed
  906dd3b

  Copy full SHA for 906dd3b

• Presuming the match on a character is more eficient than the indexOf here

  eoghanmurray

  committed
  e0fb33d

  Copy full SHA for e0fb33d

• Fix eslint

  eoghanmurray

  committed
  f5fcfa5

  Copy full SHA for f5fcfa5

• Update puppeteer to try to solve the following issue in github actions:

  Show description for a797e96
  eoghanmurray

  committed
  a797e96

  Copy full SHA for a797e96

• Bump Chrome to see if it solves following issue in github actions:

  Show description for defd363
  eoghanmurray

  committed
  defd363

  Copy full SHA for defd363

• Both Firefox and the 131 version of Chrome I've upgraded to remove default css values from shorthand properties when retrieved via sheet.rules[0].cssText

  eoghanmurray

  committed
  ad42cba

  Copy full SHA for ad42cba

• Drop chrome down again as getting overwhelmed with issues so will see if this LTS version also solves:

  Show description for dec4ad5
  eoghanmurray

  committed
  dec4ad5

  Copy full SHA for dec4ad5

• Bump all puppeteer to match the LTS version of chrome we've just specified - going by https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

  eoghanmurray

  committed
  7d1e100

  Copy full SHA for 7d1e100

• Fix json error

  eoghanmurray

  committed
  0c809e1

  Copy full SHA for 0c809e1

• The previous version combo didn't install, trying next one up

  eoghanmurray

  committed
  2bae508

  Copy full SHA for 2bae508

• Still getting 'zygote_host_impl_linux.cc(128)] No usable sandbox!' so iterating through versions

  eoghanmurray

  committed
  c43d695

  Copy full SHA for c43d695

• Keep searching through https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

  eoghanmurray

  committed
  e16e2ac

  Copy full SHA for e16e2ac

• Following https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md

  eoghanmurray

  committed
  c0bf8f8

  Copy full SHA for c0bf8f8

• Continuing with https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md

  eoghanmurray

  committed
  417a831

  Copy full SHA for 417a831

• Another bump to find minimum version to remove the 'No Usable Sandbox' error

  eoghanmurray

  committed
  a72a28e

  Copy full SHA for a72a28e

• Final bump to top of https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

  eoghanmurray

  committed
  a677fb6

  Copy full SHA for a677fb6

• Further bump of Chrome as issue still isn't solved - this previously seemed to solve things

  eoghanmurray

  committed
  9086b94

  Copy full SHA for 9086b94

• Revert all puppeteer and chrome related changes as the problem was fixed with runs-on: ubuntu-22.04

  eoghanmurray

  committed
  724a27b

  Copy full SHA for 724a27b

• I keep accidentally forgetting camelCase

  eoghanmurray

  committed
  0fbf355

  Copy full SHA for 0fbf355