fix: don't bundle everything into console recorder #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 44ada0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
pauldambra
commented
Nov 2, 2024
pauldambra
commented
Nov 2, 2024
| @@ -1,7 +1,7 @@ | |||
| import type { listenerHandler, RecordPlugin, IWindow } from '@rrweb/types'; | |||
| import { utils } from 'rrweb'; | |||
There was a problem hiding this comment.
this is the fix here... this line was including the whole of rrweb
Juice10
requested changes
Dec 6, 2024
There was a problem hiding this comment.
This looks really good @pauldambra, I had a couple tweaks, mainly due to the release of rrweb 2.0.0-alpha.18
But as soon as they are tackled we can merge this one and do another release.
FYI: You might have to pull in master to fix the tests, after adding the suggestions.
Co-authored-by: Justin Halsall <[email protected]>
Co-authored-by: Justin Halsall <[email protected]>
Co-authored-by: Justin Halsall <[email protected]>
Co-authored-by: Justin Halsall <[email protected]>
Juice10
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the use of
utils.patchfromrrwebin theconsoleplugin was including the whole of rrweb in the console recorder.move the patch function into the existing
@rrweb/utilspackage fixes this(I've only proven the bundle is fixed - i'm hoping CI proves the recorder still works 😅 )
just looking at bundle size this reduces the console recorder plugin from 255kb to 15kb