Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for inline images #1306

Closed
wants to merge 4 commits into from
Closed

Fix for inline images #1306

wants to merge 4 commits into from

Conversation

econte-sprig
Copy link

@econte-sprig
Fixes the bug with inline images not emitting events with an rr_dataU…
f87abb6 
…RL attribute. The recorder now will create a new img element, and when that loads it will issue a separate mutation event changing the rr_dataURL property. Also fixes a bug in the replayer which does not correctly handle changes to the rr_dataURL attribute in mutation events.
@econte-sprig
Revert "Fixes the bug with inline images not emitting events with an …
e3757cd 
…rr_dataURL attribute. The recorder now will create a new img element, and when that loads it will issue a separate mutation event changing the rr_dataURL property. Also fixes a bug in the replayer which does not correctly handle changes to the rr_dataURL attribute in mutation events."

This reverts commit f87abb6.
@econte-sprig
Fixes the bug with inline images not emitting events with an rr_dataU…
888e83e 
…RL attribute. The recorder now will create a new img element, and when that loads it will issue a separate mutation event changing the rr_dataURL property. Also fixes a bug in the replayer which does not correctly handle changes to the rr_dataURL attribute in mutation events.
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 877cf74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@econte-sprig econte-sprig mentioned this pull request Sep 14, 2023
Open
1 task
@eoghanmurray
Copy link
Contributor

I would vote to defer this PR until we can see if Justin can get #1239 complete which should solve the same issue?

@Juice10
Copy link
Contributor

Juice10 commented Dec 4, 2023

#1239 is nearly done and should fix this issue. Thanks for proposing this solution, I think it was very nicely done.

Closing the PR due to #1239

@Juice10 Juice10 closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@econte-sprig @eoghanmurray @Juice10