Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shutter1 protocol file #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ArrowX77
Copy link

@ArrowX77 ArrowX77 commented Oct 3, 2024

This is to support shutters from the brand Nobily that I have used with Pimatic and homeduino since 10 years. After changing to Home Assistant I want to automate the existing shutters.

This is to support shutters from the brand Nobily that I have used with Pimatic and homeduino since 10 years. After changing to Home Assistant I want to automate the existing shutters.
@rrooggiieerr
Copy link
Owner

Hi! Thanks for trying to contribute to this project.

Unfortunately the shutter1.py implementation does not match the structure of any of the other protocol implementations. I suggest you take a look at the other protocol implementations and try to reproduce similar code for the shutter1 protocol.

Also there needs to be a unit test added to make sure the protocol works as expected.

Let me know if you have any questions!

@rrooggiieerr
Copy link
Owner

Hi! I'm working on a new release of het HA Homeduino integration, if you could finalise this protocol it could be included.

Let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants