Use TXG_WAIT for putpage vs. retry loop

Signed-off-by: Robert Evans <[email protected]>
rrevans · Mar 20, 2024 · 5270f15 · 5270f15
1 parent c7100fc
commit 5270f15
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 22 deletions.
diff --git a/module/os/linux/zfs/zfs_vnops_os.c b/module/os/linux/zfs/zfs_vnops_os.c
@@ -3795,11 +3795,8 @@ zfs_putpage(struct inode *ip, struct page *pp, struct writeback_control *wbc,
 	dmu_tx_hold_sa(tx, zp->z_sa_hdl, B_FALSE);
 	zfs_sa_upgrade_txholds(tx, zp);
 
-	err = dmu_tx_assign(tx, TXG_NOWAIT);
+	err = dmu_tx_assign(tx, TXG_WAIT);
 	if (err != 0) {
-		if (err == ERESTART)
-			dmu_tx_wait(tx);
-
 		dmu_tx_abort(tx);
 #ifdef HAVE_VFS_FILEMAP_DIRTY_FOLIO
 		filemap_dirty_folio(page_mapping(pp), page_folio(pp));

diff --git a/module/os/linux/zfs/zpl_file.c b/module/os/linux/zfs/zpl_file.c
@@ -720,23 +720,23 @@ zpl_putpage(struct page *pp, struct writeback_control *wbc, void *data)
 {
 	boolean_t *for_sync = data;
 	fstrans_cookie_t cookie;
-	int ret;
 
 	ASSERT(PageLocked(pp));
 	ASSERT(!PageWriteback(pp));
 
 	cookie = spl_fstrans_mark();
-	ret = zfs_putpage(pp->mapping->host, pp, wbc, *for_sync);
+	(void) zfs_putpage(pp->mapping->host, pp, wbc, *for_sync);
 	spl_fstrans_unmark(cookie);
 
-	return (ret);
+	return (0);
 }
 
 #ifdef HAVE_WRITEPAGE_T_FOLIO
 static int
 zpl_putfolio(struct folio *pp, struct writeback_control *wbc, void *data)
 {
-	return (zpl_putpage(&pp->page, wbc, data));
+	(void) zpl_putpage(&pp->page, wbc, data);
+	return (0);
 }
 #endif
 

diff --git a/module/zfs/zfs_vnops.c b/module/zfs/zfs_vnops.c
@@ -122,13 +122,8 @@ zfs_holey_common(znode_t *zp, ulong_t cmd, loff_t *off)
 		hole = B_FALSE;
 
 	/* Flush any mmap()'d data to disk */
-	if (zn_has_cached_data(zp, 0, file_sz - 1)) {
-		do {
-			error = zn_flush_cached_data(zp, B_TRUE);
-		} while (error == ERESTART);
-		if (error != 0)
-			return (error);
-	}
+	if (zn_has_cached_data(zp, 0, file_sz - 1))
+		zn_flush_cached_data(zp, B_TRUE);
 
 	lr = zfs_rangelock_enter(&zp->z_rangelock, 0, UINT64_MAX, RL_READER);
 	error = dmu_offset_next(ZTOZSB(zp)->z_os, zp->z_id, hole, &noff);
@@ -1197,13 +1192,7 @@ zfs_clone_range(znode_t *inzp, uint64_t *inoffp, znode_t *outzp,
 	 */
 	if (zn_has_cached_data(inzp, inoff, inoff + len - 1)) {
 		// FIXME: flush only the cloned range
-		do {
-			error = zn_flush_cached_data(inzp, B_TRUE);
-		} while (error == ERESTART);
-		if (error != 0) {
-			zfs_exit_two(inzfsvfs, outzfsvfs, FTAG);
-			return (error);
-		}
+		zn_flush_cached_data(inzp, B_TRUE);
 	}
 
 	/*