Don't mask rpm2cpio failure in Pkg._extract_rpm()

rpm-software-management · Aug 12, 2024 · 42cdb0d · 42cdb0d
1 parent b756e42
commit 42cdb0d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/rpmlint/pkg.py b/rpmlint/pkg.py
@@ -610,7 +610,7 @@ def _extract_rpm(self, dirname, verbose):
                         subprocess.check_output('rpm2archive - | tar -xz && chmod -R +rX .', shell=True, env=ENGLISH_ENVIRONMENT,
                                                 stderr=stderr, stdin=rpm_data)
                 else:
-                    command_str = f'rpm2cpio {quote(str(filename))} | cpio -id ; chmod -R +rX .'
+                    command_str = f'rpm2cpio {quote(str(filename))} | cpio -id && chmod -R +rX .'
                     subprocess.check_output(command_str, shell=True, env=ENGLISH_ENVIRONMENT, stderr=stderr)
             self.extracted = True
         return dirname