hermetic: retry on failed network requests #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ralphbean
force-pushed
the
retry-downloads
branch
from
9cfec07 to
169bbdb
Compare
|
Thank you for working on this early feature! |
praiskup
reviewed
Nov 26, 2024
mock/py/mock-hermetic-repo.py
Outdated
| return wrapper | ||
|
|
||
|
|
||
| @retry(retry_on=requests.exceptions.ConnectionError) |
There was a problem hiding this comment.
Have you considered python-backoff? Mock already depends on it so it is not a new dep:
mock/mock/py/mockbuild/file_downloader.py
Lines 67 to 68 in 5193dbd
There was a problem hiding this comment.
Oh, no! I was not aware of it. We should use that.
I'd prefer to have a short message, nothing more than "the mock-hermetic-repo implements retry-mechanism for downloading files" is needed. |
ralphbean
force-pushed
the
retry-downloads
branch
from
169bbdb to
a6f5f46
Compare
ralphbean
force-pushed
the
retry-downloads
branch
from
a6f5f46 to
27eeb4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No release note required for this one, I think. Pretty small change.