Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnf5 groupinstall alias #1286

Closed
wants to merge 2 commits into from
Closed

dnf5 groupinstall alias #1286

wants to merge 2 commits into from

Conversation

praiskup
Copy link
Member

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jan 12, 2024 •
edited
Loading

Hello @praiskup! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 781:32: E127 continuation line over-indented for visual indent

Comment last updated at 2024-01-12 20:58:41 UTC

@packit-as-a-service Packit-as-a-Service
Copy link

We were not able to find or create Copr project packit/rpm-software-management-mock-1286 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=rpm-software-management-mock-1286 chroots=['fedora-rawhide-x86_64']): Response is not in JSON format, there is probably a bug in the API code.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@praiskup praiskup force-pushed the praiskup-dnf5-groupinstall branch from dbc3ddb to c347552 Compare January 12, 2024 20:58
@praiskup praiskup changed the title Praiskup dnf5 groupinstall dnf5 groupinstall alias Jan 12, 2024
@praiskup praiskup mentioned this pull request Jan 12, 2024
Closed
@praiskup
Copy link
Member Author

Relates to: https://pagure.io/koji/issue/3971
Relates to: rpm-software-management/dnf5#1166
Relates to: rpm-software-management/dnf5#1165

@praiskup praiskup marked this pull request as draft January 12, 2024 22:27
praiskup
praiskup commented Jan 19, 2024
View reviewed changes
mock/py/mockbuild/config.py
config_opts["dnf5_avoid_opts"] = {
"remove": ["--allowerasing"],
"groupinstall": ["--allowerasing"],
"group": ["--allowerasing"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group install will support --allowerasing in the next release rpm-software-management/dnf5#1174

praiskup
praiskup commented Jan 19, 2024
View reviewed changes
mock/py/mockbuild/package_manager.py
attached_command = 'group.install'
descr = "Alias for 'group install'"
group_id = 'commands-compatibility-aliases'
complete = true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Koji is switching to group install by default: https://pagure.io/koji/pull-request/3974

@praiskup
Copy link
Member Author

Closing. We used this for early experiments in Koji, to rule-out other integration issues.... but this is not going to be needed eventually.

@praiskup praiskup closed this Jan 19, 2024
praiskup added a commit to praiskup/mock that referenced this pull request Sep 25, 2024
@praiskup
No per-command bootstrap mount leftovers
aa01322 
The d4c1269 commit broke this use-case:

    $ mock --chain ....
    $ mock --scrub=chroot
    $ mock --scrub=bootstrap

The problem is that --chain always creates a host-local temporary
repository (directory) for built results, which is also bind-mounted to
the bootstrap chroot (so the inner packager may use the built results).

The commit started modifying bootstrap's dnf.conf, thus it added a new
bind-mount that never got unmounted.

Complements: d4c1269
Relates: rpm-software-management#1414
Relates: rpm-software-management#1286
@praiskup praiskup mentioned this pull request Sep 25, 2024
Merged
praiskup added a commit to praiskup/mock that referenced this pull request Sep 25, 2024
@praiskup
No per-command bootstrap mount leftovers
efc7580 
The d4c1269 commit broke this use-case:

    $ mock --chain ....
    $ mock --scrub=chroot
    $ mock --scrub=bootstrap

The problem is that --chain always creates a host-local temporary
repository (directory) for built results, which is also bind-mounted to
the bootstrap chroot (so the inner packager may use the built results).

The commit started modifying bootstrap's dnf.conf, thus it added a new
bind-mount that never got unmounted.

Complements: d4c1269
Relates: rpm-software-management#1414
Relates: rpm-software-management#1286
praiskup added a commit to praiskup/mock that referenced this pull request Sep 25, 2024
@praiskup
De-duplicate the local-repo mountpoint in bootstrap
591c890 
Complements: d4c1269
Relates: rpm-software-management#381
Relates: rpm-software-management#357
Relates: rpm-software-management#1414
Relates: rpm-software-management#1286
praiskup added a commit to praiskup/mock that referenced this pull request Sep 25, 2024
@praiskup
De-duplicate the local-repo mountpoint in bootstrap
7f112ff 
Complements: d4c1269
Relates: rpm-software-management#381
Relates: rpm-software-management#357
Relates: rpm-software-management#1414
Relates: rpm-software-management#1286
praiskup added a commit to praiskup/mock that referenced this pull request Sep 25, 2024
@praiskup
De-duplicate the local-repo mountpoint in bootstrap
17813b8 
The code that is being dropped is duplicated in package_manager.py.

Complements: d4c1269
Relates: rpm-software-management#381
Relates: rpm-software-management#357
Relates: rpm-software-management#1414
Relates: rpm-software-management#1286
praiskup added a commit to praiskup/mock that referenced this pull request Sep 25, 2024
@praiskup
De-duplicate the local-repo mountpoint in bootstrap
3dd0024 
The code that is being dropped is duplicated in package_manager.py.

Complements: d4c1269
Relates: rpm-software-management#381
Relates: rpm-software-management#357
Relates: rpm-software-management#1414
Relates: rpm-software-management#1286
praiskup added a commit that referenced this pull request Sep 26, 2024
@praiskup
De-duplicate the local-repo mountpoint in bootstrap
a20daa4 
The code that is being dropped is duplicated in package_manager.py.

Complements: d4c1269
Relates: #381
Relates: #357
Relates: #1414
Relates: #1286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praiskup @pep8speaks