Fix and use ModuleProfile::is_default() method
#988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
reviewed
Oct 26, 2023
pkratoch
force-pushed
the
profile-is-default
branch
from
db75bfa to
da751bf
Compare
j-mracek
reviewed
Oct 27, 2023
| const auto & modulemd_profile = static_cast<ModulemdProfile *>(g_ptr_array_index(profiles, i)); | ||
| result_profiles.push_back(ModuleProfile( | ||
| modulemd_profile, | ||
| std::find(default_profiles.begin(), default_profiles.end(), modulemd_profile_get_name(modulemd_profile)) != |
There was a problem hiding this comment.
This is not wrong, but written code in that way might be less readable (this is a personal opinion).
std::find(default_profiles.begin(), default_profiles.end(), modulemd_profile_get_name(modulemd_profile)) !=
default_profiles.end()));
It is possible to use temporal variable
bool is_default = std::find(default_profiles.begin(), default_profiles.end(), modulemd_profile_get_name(modulemd_profile)) !=
default_profiles.end()));
There was a problem hiding this comment.
Indeed, temporals are a simple yet powerful way to make complex conditions far more readable, even obvious.
The previously used `modulemd_profile_is_default` gets the information about defaults from modulemd-packager yaml document, which is available when building a module, but doesn't work for modules after building.
pkratoch
force-pushed
the
profile-is-default
branch
from
da751bf to
e1519dc
Compare
|
LGTM |
|
@pkratoch May I ask you whether there is any blocker why CI tests for module list cannot be enabled |
Oh, good point. I'll take a look at which tests could be enabled now. |
Merged
via the queue into
rpm-software-management:main
with commit Oct 27, 2023
35c6491
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.