Fix throwing exceptions, allow only "safe" types #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrohel
force-pushed
the
fix/passing_exceptions_args
branch
from
c4dd9d5 to
f9b4dcb
Compare
jrohel
force-pushed
the
fix/passing_exceptions_args
branch
2 times, most recently
from
9db6573 to
ff54c76
Compare
|
Doc text for |
The exception stores the passed arguments and uses them in the catch phase. The problem is that the text to which the saved argument points may no longer be in memory - is destroyed when the program leaves the scope of the variable with the text. A safer solution than passing a pointer to memory is to use "std::string" and pass it by value.
"move" semantics now works for rvalue arguments.
…ctors Exceptions were generated in the code, in which a pointer to text was passed that was no longer in memory at the time the exception was handled. To prevent this from happening again, passing only defined "safe" types is now allowed.
jrohel
force-pushed
the
fix/passing_exceptions_args
branch
from
ff54c76 to
8ec790d
Compare
|
I added a commit fixing |
Thanks! |
Merged
via the queue into
rpm-software-management:main
with commit Oct 25, 2023
73443c0
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions were thrown in the code, in which a pointer to text was passed that was no longer in memory at the time the exception was handled.
Fix: Replaced passing
char *andconst char *withstd::stringwhen throwing exception.To prevent this from happening again, passing only defined "safe" types is now allowed.