During package donwload setup first add all downloads then handle local #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Color code sequence can look like: `ESC[32m`, we need to handle two digits after `ESC[`. Also add better reporting when an unknown sequence is found.
This caused atleast two problems: 1. When the first package was local and its `end` callback was called immediately it updated and printed the MultiProgressBar which thought that its finished (because it contained only one finished bar). This lead to an extra new line being printed which broke the output, reported here: rpm-software-management#1957 2. The numbering of bars was wrong, most noticeable with bigger transactions with some already downloaded packages. It could look like: ``` Transaction Summary: Installing: 296 packages Total size of inbound packages is 414 MiB. Need to download 412 MiB. After this operation, 1 GiB extra will be used (install 1 GiB, remove 0 B). Is this ok [y/N]: y [1/1] libreoffice-1:24.8.4.2-2.fc41.x86_64 100% | 0.0 B/s | 0.0 B | 00m00s >>> Already downloaded ----------------------------------------------------------------------------------------------------------------------------------------- [1/2] libreoffice-base-1:24.8.4.2-2.fc41.x86_64 100% | 0.0 B/s | 0.0 B | 00m00s >>> Already downloaded ----------------------------------------------------------------------------------------------------------------------------------------- [1/4] libreoffice-draw-1:24.8.4.2-2.fc41.x86_64 100% | 0.0 B/s | 0.0 B | 00m00s >>> Already downloaded ----------------------------------------------------------------------------------------------------------------------------------------- [2/5] libreoffice-emailmerge-1:24.8.4.2-2.fc41.x86_64 100% | 0.0 B/s | 0.0 B | 00m00s >>> Already downloaded ----------------------------------------------------------------------------------------------------------------------------------------- [3/6] libreoffice-impress-1:24.8.4.2-2.fc41.x86_64 100% | 0.0 B/s | 0.0 B | 00m00s >>> Already downloaded ----------------------------------------------------------------------------------------------------------------------------------------- [4/7] libreoffice-math-1:24.8.4.2-2.fc41.x86_64 100% | 0.0 B/s | 0.0 B | 00m00s >>> Already downloaded ----------------------------------------------------------------------------------------------------------------------------------------- [ 5/296] libreoffice-calc-1:24.8.4.2-2.fc41.x86_64 0% [<=> ] | 1.0 B/s | 0.0 B | 97d15h ```
kontura
force-pushed
the
local_pkg_targets
branch
from
14ad568 to
3ebf1c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the last commit for details.
The new unit test doesn't test the fix but I have created it during development and it seems valuable enough to keep.
A proper test would probably need to be added to
ci-dnf-stackbecause it requires dnf5DownloadCallbacks.