Copr plugin: Fix resource leak in load_all_configuration #1988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a resource leak while working on #1893.
There was a missing
globfree
function call in theCoprConfig::load_all_configuration()
method.One can say that adding the line
globfree(&glob_result);
after thefor
loop is enough. But it's not true. Theload_copr_config_file
method called in the loop can generate an exception. So I rewrote the code to usestd::filesystem::directory_iterator
.