download: add --srpm option
#1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
requested changes
Jan 29, 2024
principis
force-pushed
the
download-source-option
branch
from
4f5c868 to
a724d6e
Compare
|
Thanks for the feedback! I updated the PR. I'm not sure if this is the best way to do this, but I couldn't find something else. Edit: Also renamed variables and commit message |
principis
force-pushed
the
download-source-option
branch
from
a724d6e to
a7624cb
Compare
|
(I have also prepared a PR with enabled CI tests once we merge this: rpm-software-management/ci-dnf-stack#1443) |
|
Could you also add a note to |
principis
force-pushed
the
download-source-option
branch
from
a7624cb to
311e2e6
Compare
principis
force-pushed
the
download-source-option
branch
from
311e2e6 to
146145a
Compare
|
Sorry for the delay, I was on vacation. I've made the requested changes and rebased the branch, thank you for the review! |
|
Thank you for the contribution! |
Merged
via the queue into
rpm-software-management:main
with commit Feb 19, 2024
78d7b76
10 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #947
Implements the
--sourceoption for the download command to download only the source rpm(s).