Added arch option to the download command #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
requested changes
Feb 6, 2024
doc/commands/download.8.rst
Outdated
| @@ -53,6 +53,8 @@ Options | |||
| ``--urlprotocol`` | |||
| | To be used together with ``--url``. It filters out the URLs to the specified protocols: ``http``, ``https``, ``ftp``, or ``file``. This option can be used multiple times. | |||
|
|
|||
| ``--arch`` | |||
| | Filters the query to packages of given architectures. This option can be usd multiple times. | |||
There was a problem hiding this comment.
Minor: I think it would be cleaner if we wrote just: Limit to packages of given architectures.
Also there is a typo: option can be usd -> option can be used.
dnf5/commands/download/download.cpp
Outdated
| arch_option = {}; | ||
| auto arch = parser.add_new_named_arg("arch"); | ||
| arch->set_long_name("arch"); | ||
| arch->set_description("limit the query to packages of given architectures."); |
There was a problem hiding this comment.
I would prefer: Limit to packages of given architectures.
dnf5/commands/download/download.cpp
Outdated
| arch->set_long_name("arch"); | ||
| arch->set_description("limit the query to packages of given architectures."); | ||
| arch->set_has_value(true); | ||
| arch->set_arg_value_help("ARCH...,"); |
There was a problem hiding this comment.
The patter we use here is --enable-plugin=PLUGIN_NAME,....
Can you move the comma? -> ARCH,...
derickdiaz
force-pushed
the
arch-option
branch
from
473f66e to
4352070
Compare
Merged
via the queue into
rpm-software-management:main
with commit Feb 7, 2024
40d2218
5 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #946
Add the --arch option to the download command. Filters queried compatible packages based on the specified architectures. If the architecture needs to be changed, the users can use the global --forcearch to change the base architecture.