Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnfdaemon: Exlicitely specify allowed config overrides #1201

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Jan 24, 2024

Limit main config options overrides for dnfdaemon session only to
those explicitely allowed.

@inknos
Copy link
Collaborator

inknos commented Jan 24, 2024

dnf5daemon tests are expected to fail (dnf is failing as well for different reasons). we might want to merge this #1202 before in order to check the daemon manually once it's fixed

@inknos
Copy link
Collaborator

inknos commented Jan 24, 2024

there's also a typo in the commit message btw, Exlicitely->Explicitly. other than that LGTM

Limit main config options overrides for dnfdaemon session only to
those explicitely allowed.
@m-blaha m-blaha force-pushed the mblaha/dnfdaemon-allowed-options branch from c85b48a to 8789f43 Compare January 24, 2024 17:06
@m-blaha
Copy link
Member Author

m-blaha commented Jan 24, 2024

Thank you, I've fixed the commit message.

@inknos inknos added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 6e51bf2 Jan 24, 2024
5 of 9 checks passed
@inknos inknos deleted the mblaha/dnfdaemon-allowed-options branch January 24, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants