Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added urlprotocol option #1197

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Added urlprotocol option #1197

merged 1 commit into from
Jan 25, 2024

Conversation

derickdiaz
Copy link
Contributor

Fixes #950

  • Implements --urlprotocols to the download command and limits the valid package urls to the set url protocols.
  • If no protocols are specified, all protocols are considered valid.

@derickdiaz
Copy link
Contributor Author

derickdiaz commented Jan 23, 2024 •
edited
Loading

Works for when users specify multiple url protocols and single url protocol
image

Additionally, if an invalid url protocol is specified the following error will occur
Screenshot 2024-01-23 at 9 30 44 AM

@ppisar
Copy link
Contributor

ppisar commented Jan 23, 2024

Please document this new option in dnf5-download manual page (doc/commands/download.8.rst file).

@ppisar ppisar self-assigned this Jan 23, 2024
@ppisar
Copy link
Contributor

ppisar commented Jan 23, 2024

Could you change the commit message to "Add --urlprotocol option to download command"?

@derickdiaz derickdiaz mentioned this pull request Jan 24, 2024
Closed
@derickdiaz
Copy link
Contributor Author

I added documentation for the url option within this PR as well.

@derickdiaz derickdiaz force-pushed the urlprotocol-option branch 4 times, most recently from 654ac4d to 33fbf59 Compare January 24, 2024 17:39
ppisar
ppisar reviewed Jan 25, 2024
View reviewed changes
doc/commands/download.8.rst Outdated Show resolved Hide resolved
ppisar
ppisar reviewed Jan 25, 2024
View reviewed changes
doc/commands/download.8.rst Outdated Show resolved Hide resolved
ppisar
ppisar reviewed Jan 25, 2024
View reviewed changes
doc/commands/download.8.rst Outdated Show resolved Hide resolved
@ppisar
Copy link
Contributor

ppisar commented Jan 25, 2024

Otherwise, the code looks and works well.

ppisar
ppisar approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@ppisar ppisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's good. Thanks.

@ppisar ppisar added this pull request to the merge queue Jan 25, 2024
Merged via the queue into rpm-software-management:main with commit 7e2b964 Jan 25, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kontura kontura kontura left review comments

@ppisar ppisar ppisar approved these changes

Assignees

@ppisar ppisar

Labels
None yet
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement dnf download --urlprotocol
3 participants
@derickdiaz @ppisar @kontura