Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N: Annotate literals in advisory command #1161

Merged
merged 1 commit into from
Jan 17, 2024
Merged

I18N: Annotate literals in advisory command #1161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dnf5daemon-client/commands/advisory/arguments.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ class AdvisorySeverityOption : public libdnf5::cli::session::AppendStringListOpt
command,
"advisory-severities",
'\0',
/* Note for translators: "critical" etc. quoted words are
literals that should not be translated. */
_("Limit to packages in advisories with specified severity. List option. Can be "
Copy link
Contributor

@j-mracek j-mracek Jan 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curios whether we should use C_() to add a context for translators instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation contexts are for distinguishing two identical messages for a need of different translations. This is not the case. This message only exists at two places dnf5/commands/advisory_shared.hpp and dnf5daemon-client/commands/advisory/arguments.hpp. The messages has the same meaning and use (their code and method name is actually a duplicate), so no artificial context is needed here.

"\"critical\", \"important\", \"moderate\", \"low\", \"none\"."),
_("ADVISORY_SEVERITY,..."),
Expand Down
Loading