package_query: Fix filter_version with non EQ comparator #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the filter_version and filter_release filters always uses the cmp_eq comparator. This means that these filters only work with EQ and NEQ comparisons. The patch fixes these filters to work correctly with LT, LTE, GT, and GTE comparisons as well.
Now the tests use also LT, LTE, GT, and GTE comparisons.
|
LGTM, Thank you for the patch |
|
I have to test it locally |
|
Actually if you check testing farm results (e.g. here https://artifacts.dev.testing-farm.io/70790912-a7e2-41e2-8d9e-758da7d0ef10/) and switch on "show passed tests" on top of the page, you will see that only failing tests are dnf4 ones. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
filter_versionandfilter_releasefiltersalways uses the
cmp_eqcomparator. This means that these filters only workwith EQ and NEQ comparisons. The patch fixes these filters to work
correctly with LT, LTE, GT, and GTE comparisons as well.