Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose utis/fs/file.hpp and temp.hpp on API #1050

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Nov 28, 2023

It can be used in copr_plugin/json.cpp and I would like to use it in history store command.

Made as a part of: #999

@j-mracek
Copy link
Contributor

I have nothing against making the code public, but I would prefer to revisit exceptions and logging when something fails.

It throw std::filesystem::filesystem_error(), and the question is whether it should inherit from libdnf exceptions to prevent core dumps.

@kontura
Copy link
Contributor Author

kontura commented Nov 28, 2023

I have nothing against making the code public, but I would prefer to revisit exceptions and logging when something fails.

It throw std::filesystem::filesystem_error(), and the question is whether it should inherit from libdnf exceptions to prevent core dumps.

That sounds like a good idea to me, I will do the changes.

@kontura
Copy link
Contributor Author

kontura commented Nov 28, 2023

@j-mracek I have added a commit with the new exception.

This allows catching the excetions by dnf5 and returning exit code
insteaad of a traceback.
@kontura
Copy link
Contributor Author

kontura commented Nov 29, 2023

Test update: rpm-software-management/ci-dnf-stack#1413 - It is needed because the text of the exception changed a little.

@j-mracek
Copy link
Contributor

LGTM

@j-mracek j-mracek added this pull request to the merge queue Nov 29, 2023
@j-mracek j-mracek self-assigned this Nov 29, 2023
Merged via the queue into rpm-software-management:main with commit 3c1e84e Nov 29, 2023
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants