Fix: Passing args in "libdnf5::Error" and "libdnf5::SystemError" ctors

"move" semantics now works for rvalue arguments.
rpm-software-management · Oct 19, 2023 · a5f7691 · a5f7691
1 parent d22ec04
commit a5f7691
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/include/libdnf5/common/exception.hpp b/include/libdnf5/common/exception.hpp
@@ -132,8 +132,8 @@ class Error : public std::runtime_error {
     ///
     /// @param format The format string for the message.
     /// @param args The format arguments.
-    template <typename... Ss>
-    explicit Error(BgettextMessage format, Ss &&... args)
+    template <typename... Args>
+    explicit Error(BgettextMessage format, Args... args)
         : std::runtime_error(b_gettextmsg_get_id(format)),
           format(format),
           // stores the format args in the lambda's closure
@@ -172,9 +172,9 @@ class SystemError : public Error {
     /// @param error_code The `errno` of the error.
     /// @param format The format string for the message.
     /// @param args The format arguments.
-    template <typename... Ss>
-    explicit SystemError(int error_code, BgettextMessage format, Ss &&... args)
-        : Error(format, std::forward<Ss>(args)...),
+    template <typename... Args>
+    explicit SystemError(int error_code, BgettextMessage format, Args... args)
+        : Error(format, std::forward<Args>(args)...),
           error_code(error_code),
           has_user_message(true) {}