Add --json tests for repo and advisory list commands
#1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The json string values can contain fnmatch patterns. Adding a new step rather than using "stdout matches line by line" because json format contains a lot of brackets that would need to be escaped when the whole line is considered a regex. It would make the expected output hard to read. In addition to that the ordering can vary, this step compares ordered jsons.
kontura
force-pushed
the
json
branch
3 times, most recently
from
e46cfbb to
15ad5bd
Compare
m-blaha
reviewed
Jul 31, 2024
| """ | ||
|
|
||
|
|
||
| Scenario: Repo list without arguments --json --refresh --quiet |
There was a problem hiding this comment.
Is there a reason for this scenario? It seems to be essentially the same as the Repo list without arguments --json, and I'm not sure why the --refresh and --quiet options are important. Could you clarify their significance?
There was a problem hiding this comment.
It was meant to test that <REPOSYNC> doesn't get into the stdout.
It was really confusing and wrong.
The --quiet is not needed because its implicitly set by --json and I have changed it to repo info because repo list doesn't need metadata.
I have updated it.
Thank you for catching that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--jsontests forrepoandadvisory listcommands