Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set EXTEXCLALL when enabling multi-core operation #898

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

jannic
Copy link
Member

@jannic jannic commented Feb 6, 2025

Fixes #897

Also adds an on-target test to verify that atomics are working, and fixes initialization between on-target tests.

@thejpster
Copy link
Member

Looks great.

Does the test fail if you don't enable the bit?

@jannic
Copy link
Member Author

jannic commented Feb 7, 2025

Does the test fail if you don't enable the bit?

Yes, and with a huge difference in the counter value:

(1/1) running `check_atomics`...
ERROR panicked at tests/multicore.rs:103:9:
assertion `left == right` failed
  left: 200000
 right: 100001

@thejpster
Copy link
Member

Excellent!

@jannic jannic merged commit a7197d4 into rp-rs:main Feb 8, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix atomics on RP2350
2 participants