Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output of rom_funcs example a bit more consistent #896

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

jannic
Copy link
Member

@jannic jannic commented Feb 4, 2025

Before:

Reading OTP_DATA
	RP2350 Package ID: 0xa9e3aa32
	RP2350 Device ID : 0xafa893f7
Reading OTP_DATA_RAW
	RP2350 Package ID: 0x001faa32 0x0031a9e3
	RP2350 Device ID : 0x002093f7 0x001aafa8
get_sys_info(CHIP_INFO/0x0001)
	RP2350 Package ID: 0x00000000
	RP2350 Device ID : 0xa9e3aa32
	RP2350 Wafer ID  : 0xafa893f7

After:

Reading OTP_DATA
	RP2350 Device ID: 0xa9e3aa32
	RP2350 Wafer ID : 0xafa893f7
Reading OTP_DATA_RAW
	RP2350 Device ID: 0x001faa32 0x0031a9e3
	RP2350 Wafer ID : 0x002093f7 0x001aafa8
get_sys_info(CHIP_INFO/0x0001)
	RP2350 Package  : 0x00000000 (QFN80, but wrong on A2 stepping)
	RP2350 Device ID: 0xa9e3aa32
	RP2350 Wafer ID : 0xafa893f7

@thejpster
Copy link
Member

Apologies for the mixup - the datasheet is confusing.

@jannic
Copy link
Member Author

jannic commented Feb 4, 2025

Apologies for the mixup - the datasheet is confusing.

Yes, the datasheet could be better. Also, I'm not sure if the distinction between Wafer ID and Device ID is correct. Picotool reports them as one number: chipid: 0xafa893f7a9e3aa32, and Table 1361. "List of OTP_DATA registers" also only mentions one 64-bit public device id (split into 4 parts of 16 bit each).

But the datasheet does document get_sys_info as returning two 32-bit values, device id and wafer id. So let's keep it that way.

@jannic jannic merged commit d927dce into rp-rs:main Feb 4, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants