Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger #46

Draft
wants to merge 329 commits into
base: main
Choose a base branch
from
Draft

Debugger #46

wants to merge 329 commits into from
+4,496 −137

Conversation

dxrcy
Copy link
Contributor

@dxrcy dxrcy commented Oct 5, 2024 •
edited
Loading

See proposal: #43

rozukke
rozukke reviewed Oct 5, 2024
View reviewed changes
Copy link
Owner

@rozukke rozukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major qualms with what I can see, though obviously there is code duplication that can be improved after both use-cases are a bit more set in stone. I've skimmed over it, but will take a more detailed read today or tomorrow.

dxrcy added 29 commits November 28, 2024 12:09
@dxrcy
lint: tidy terminal_cursor functions
fc03139
@dxrcy
lint: tidy debugger::print module
f489aa0
@dxrcy
refactor: convert 'minimal' static variable into module
eca1b08
@dxrcy
refactor: convert 'line start' static variable into module
dda915f
@dxrcy
Merge remote-tracking branch 'origin/main' into debugger
a7b3aa8
@dxrcy
Merge remote-tracking branch 'origin/main' into debugger
a135bfb
@dxrcy
Merge remote-tracking branch 'origin/main' into debugger
21ab64c
@dxrcy
fix: use updated runtime api in debugger code
b1f39f0
@dxrcy
refactor: convert RunState::pc to immutable
e70bc72
@dxrcy
fix: update comments
5bc84f6
@dxrcy
fix: use correct address for breakpoints
8bfb140
@dxrcy
feat: print registers as hex, int, uint, and char
da7fee7
@dxrcy
refactor: separate print_* methods from Debugger
ec6a84c
@dxrcy
feat: print table header for registers command
2793c9e
@dxrcy
refactor: make print_registers generic for impl io::Write
f052840
@dxrcy
feat: use debugger print_registers for REG trap
dc40087
@dxrcy
feat: align register print to columns
82fbb0e
@dxrcy
feat: use box-drawing characters for register print
cc4f642
@dxrcy
feat: style register print
c9b0a8b
@dxrcy
feat: change non-printable character in register print
0bdf6bd
@dxrcy
feat: remove temporary debug prints
527acc3
@dxrcy
feat: print some debugger info only if not --minimal
781b5a1
@dxrcy
refactor!: use Output struct for all printing in program
5086d24
@dxrcy
fix: debugger newlines
1884a83
@dxrcy
feat: set line start on Normal print_str
a5be80c
@dxrcy
fix: terminal source uses correct prompt style
acd70fc
@dxrcy
feat: don't print eof indicator in minimal output
60dc84e
@dxrcy
fix: start line on REG trap
b41204c
@dxrcy
refactor: move debugger print functions to output module
626b8db
dxrcy added 30 commits February 7, 2025 15:29
@dxrcy
feat: naive type check before parsing
25c8520
@dxrcy
test: fix label tests
e3e01cd
@dxrcy
fix: add correct address offset to account for pc
93460c7
@dxrcy
refactor: reference strings in command struct, instead of allocing
ba9d1db
@dxrcy
doc: update safety comment
8c4953b
@dxrcy
refactor: remove unnecessary boxing to make &str static
5504a6e
@dxrcy
refactor: make command types reference input string
1f3dcd1
@dxrcy
feat: revert to label resolution on execution
4df3534
@dxrcy
refactor: change debugger color constants
bbcd638
@dxrcy
test: fix labels
e90dfe2
@dxrcy
lint(debugger): clippy
ee66f85
@dxrcy
refactor: move command parsing to submodule
aba38f8
@dxrcy
refactor: separate parsing into submodules
c6bd129
@dxrcy
refactor: split parsing modules into files
64be591
@dxrcy
refactor: create TryParse trait
0f34d0c
@dxrcy
refactor: create Integer wrapper type
8a413b4
@dxrcy
refactor: implement TryParse for Integer
f5fa06b
@dxrcy
fix: required sign for integers
3504971
@dxrcy
chore: tidy label.rs
fa3e966
@dxrcy
doc: fix doc issues
19427ec
@dxrcy
refactor: unify parsing functions
2a41787
@dxrcy
refactor: convert error wrapping function to method
5e7711f
@dxrcy
refactor: move command read/parse method to command module
a1a0da1
@dxrcy
refactor: rename ArgIter
cd132d1
@dxrcy
feat: show correct argument count
d4e0135
@dxrcy
refactor: reorder Arguments methods
68cfd46
@dxrcy
chore: update doc comments in command module
1a26721
@dxrcy
fix: argument parsing order
0ef25cf
@dxrcy
test(command): fix compile issues
8d21d2b
@dxrcy
test(command): fix integer test bugs
439ee1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozukke rozukke rozukke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dxrcy @rozukke